Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Small files to typescript #30665

Merged
merged 5 commits into from
Oct 18, 2023
Merged

refactor: Small files to typescript #30665

merged 5 commits into from
Oct 18, 2023

Conversation

KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: ac0d689

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #30665 (4b43546) into develop (f3dd127) will decrease coverage by 5.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30665      +/-   ##
===========================================
- Coverage    51.30%   45.55%   -5.75%     
===========================================
  Files          811      760      -51     
  Lines        15054    14538     -516     
  Branches      2749     2762      +13     
===========================================
- Hits          7723     6623    -1100     
- Misses        6924     7506     +582     
- Partials       407      409       +2     
Flag Coverage Δ
e2e 41.84% <ø> (-6.74%) ⬇️
unit 64.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 18, 2023
@KevLehman KevLehman marked this pull request as ready for review October 18, 2023 17:22
@KevLehman KevLehman requested review from a team as code owners October 18, 2023 17:22
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 18, 2023
@kodiakhq kodiakhq bot merged commit 0838406 into develop Oct 18, 2023
@kodiakhq kodiakhq bot deleted the refactor/random-ts branch October 18, 2023 19:07
gabriellsh added a commit that referenced this pull request Oct 20, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  docs: Fixed typo in FEATURES.md (#30683)
  refactor(uikit): uikit interactions (#30534)
  feat: add trial flag to licenses.info endpoint (#30662)
  refactor: Small files to typescript (#30665)
  feat: Added new setting 'Hide conversation after closing' (#30591)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants